Adds unsubscribe method #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'sid' parameter is the 'sid' returned by the subscribe method.
|
Thanks Julien! I did not implement unsubscribe initially because I had no need for it so interested in knowing that you do. When I was thinking about it I was wondering about making the client "smarter" by unsubscribing by "subject" instead of sid i.e. the client keeps track of what sid is associated to what subscription so the user does not have to. Would that work for you? |
|
Hi Eugene,
First, thank you for you project.
I have a client which need to dynamically subscribe or unsubscribe to
multiple subjects.
It's my component which keeps track of the matching between SID and subject
names.
Ultimately, it's up to you to decide how you want to improve your client
library, but I would prefer to keep the SID approach.
I see your client library as a 'low level' library. It does not do magical
internal stuff which I can't understand. If you begin to add an internal
matching table between SID and subjects, you add your own logic, which is
different from the NATS logic.
So, I would prefer to keep the SID approach. This is my opinion :)
Anyway, maybe you would implement it differently, that's fine.
Best Regards,
Julien.
Le jeu. 16 sept. 2021 à 09:58, Eugene Van den Bulke <
***@***.***> a écrit :
… Thanks Julien!
I did not implement unsubscribe initially because I had no need for it so
interested in knowing that you do.
When I was thinking about it I was wondering about making the client
"smarter" by unsubscribing by "subject" instead of sid i.e. the client
keeps track of what sid is associated to what subscription so the user does
not have to.
Would that work for you?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'sid' parameter is the 'sid' returned by the subscribe method.